Use ordinal string operations #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnis
reviewed
Mar 27, 2023
| @@ -681,7 +681,7 @@ public void ReverseRoute(Header header) | |||
| this.Header.RemoveField(Tags.OnBehalfOfLocationID); | |||
| this.Header.RemoveField(Tags.DeliverToLocationID); | |||
|
|
|||
| if (beginString.CompareTo("FIX.4.1") >= 0) | |||
| if (string.CompareOrdinal(beginString, "FIX.4.1") >= 0) | |||
There was a problem hiding this comment.
As recommended by Microsoft - it's better to use Equals method to test equality, isn't it ?
if (beginString.Equals("FIX.4.1", StringComparison.InvariantCulture))also, magic string "FIX.4.1" - can it be converted to a const?
There was a problem hiding this comment.
You're right, but here we are not checking for equality (of FIX version 4.1), rather that we are at version 4.1 or higher (from the >=).
|
Looks like this should be merged asap. |
|
can we have this change merged soon? |
|
Oops-- earlier this week I fixed some of these myself (noticed the errors in my IDE), but I used InvariantCulture. In retrospect, that was stupid of me, because Ordinal is clearly more appropriate. Going to rebase your PR and fix those (newly created by me) conflicts. |
Enables CA1310 at error severity
Also use Contains instead of IndexOf
It is unnecessary to have in the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an .editorconfig file enabling CA1310 (Specify StringComparison for correctness) at 'error' severity and fixes violations by using ordinal string operations.
Ref #713 (comment)